[PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition

[Kandpal, Suraj]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Tuesday, April 16, 2024 1:08 PM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-gfx at lists.freedesktop.org
> Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; Shankar,
> Uma <uma.shankar at intel.com>; Nautiyal, Ankit K
> <ankit.k.nautiyal at intel.com>; Bhadane, Dnyaneshwar
> <dnyaneshwar.bhadane at intel.com>; Kandpal, Suraj
> <suraj.kandpal at intel.com>
> Subject: Re: [PATCH 1/2] drm/i915: Add SCLKGATE_DIS register definition
> 
> On Tue, 16 Apr 2024, Suraj Kandpal <suraj.kandpal at intel.com> wrote:
> > Add SCLKGATE_DIS register and it's register definition which will be
> > used the next patch.
> 
> Please just squash this into the next patch.
> 
> (And please don't reference "the next patch" in commit messages, because
> it's meaningless once this becomes a commit in the history.)
> >

Sure will squash this with the next patch.

> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_reg.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h index 3f34efcd7d6c..beec91a2f493
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -6250,6 +6250,10 @@ enum skl_power_gate {
> >  #define  SFUSE_STRAP_DDIC_DETECTED	(1 << 1)
> >  #define  SFUSE_STRAP_DDID_DETECTED	(1 << 0)
> >
> > +/* SCLKGATE_DIS */
> 
> The comment is useless.
> 

Will drop it

Regards,
Suraj Kandpal
> BR,
> Jani.
> 
> > +#define SCLKGATE_DIS			_MMIO(0xc2014)
> > +#define  DPLS_GATING_DISABLE		REG_BIT(29)
> > +
> >  #define WM_MISC				_MMIO(0x45260)
> >  #define  WM_MISC_DATA_PARTITION_5_6	(1 << 0)
> 
> --
> Jani Nikula, Intel