[PATCH 4/6] drm/i915/dp: Drop comments on EDP HDR DPCD registers

[Murthy, Arun R]

> -----Original Message-----
> From: Kandpal, Suraj <suraj.kandpal at intel.com>
> Sent: Monday, April 22, 2024 9:03 AM
> To: intel-gfx at lists.freedesktop.org
> Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; Shankar,
> Uma <uma.shankar at intel.com>; Nautiyal, Ankit K
> <ankit.k.nautiyal at intel.com>; Murthy, Arun R <arun.r.murthy at intel.com>;
> Kumar, Naveen1 <naveen1.kumar at intel.com>; sebastian.wick at redhat.com;
> Kandpal, Suraj <suraj.kandpal at intel.com>
> Subject: [PATCH 4/6] drm/i915/dp: Drop comments on EDP HDR DPCD registers
> 
> Drop comments for EDP HDR DPCD registers as the code and conditions will tell
> us what can be written where.
> 
> --v2
> -Drop the comments altogether instead of just renaming them [Sebastian]
> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>

Reviewed-by: Arun R Murthy <arun.r.murthy at intel.com>

Thanks and Regards,
Arun R Murthy
--------------------
> ---
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 3d9723714c96..b61bad218994 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -69,14 +69,14 @@
>  #define INTEL_EDP_HDR_GETSET_CTRL_PARAMS                               0x344
>  # define INTEL_EDP_HDR_TCON_2084_DECODE_ENABLE                        BIT(0)
>  # define INTEL_EDP_HDR_TCON_2020_GAMUT_ENABLE                         BIT(1)
> -# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE                       BIT(2)
> /* Pre-TGL+ */
> +# define INTEL_EDP_HDR_TCON_TONE_MAPPING_ENABLE                       BIT(2)
>  # define INTEL_EDP_HDR_TCON_SEGMENTED_BACKLIGHT_ENABLE
> BIT(3)
>  # define INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE                     BIT(4)
>  # define INTEL_EDP_HDR_TCON_SRGB_TO_PANEL_GAMUT_ENABLE
> BIT(5)
>  /* Bit 6 is reserved */
>  # define INTEL_EDP_HDR_TCON_SDP_OVERRIDE_AUX
> BIT(7)
> 
> -#define INTEL_EDP_HDR_CONTENT_LUMINANCE                                0x346 /*
> Pre-TGL+ */
> +#define INTEL_EDP_HDR_CONTENT_LUMINANCE                                0x346
>  #define INTEL_EDP_HDR_PANEL_LUMINANCE_OVERRIDE                         0x34A
>  #define INTEL_EDP_SDR_LUMINANCE_LEVEL                                  0x352
>  #define INTEL_EDP_BRIGHTNESS_NITS_LSB                                  0x354
> --
> 2.43.2