✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: implicit dev_priv removal

Patchwork patchwork at emeril.freedesktop.org
Tue Apr 30 12:09:49 UTC 2024


== Series Details ==

Series: drm/i915/psr: implicit dev_priv removal
URL   : https://patchwork.freedesktop.org/series/133062/
State : warning

== Summary ==

Error: dim checkpatch failed
4414bea058fd drm/i915: pass dev_priv explicitly to TRANS_EXITLINE
51a28d8826c9 drm/i915: pass dev_priv explicitly to EDP_PSR_CTL
631a7715e20a drm/i915: pass dev_priv explicitly to TRANS_PSR_IMR
-:21: ERROR:CODE_INDENT: code indent should use tabs where possible
#21: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1459:
+^I^I^I^I           TRANS_PSR_IMR(dev_priv, trans),$

-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1459:
+			intel_uncore_write(uncore,
+				           TRANS_PSR_IMR(dev_priv, trans),

-:22: ERROR:CODE_INDENT: code indent should use tabs where possible
#22: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1460:
+^I^I^I^I           0xffffffff);$

total: 2 errors, 0 warnings, 1 checks, 26 lines checked
37d385c3faca drm/i915: pass dev_priv explicitly to TRANS_PSR_IIR
-:21: ERROR:CODE_INDENT: code indent should use tabs where possible
#21: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:880:
+^I^I^I^I^I^I        intel_dp->psr.transcoder);$

-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:880:
+				iir_reg = TRANS_PSR_IIR(dev_priv,
+						        intel_dp->psr.transcoder);

-:31: ERROR:CODE_INDENT: code indent should use tabs where possible
#31: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1463:
+^I^I^I^I           TRANS_PSR_IIR(dev_priv, trans),$

-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1463:
+			intel_uncore_write(uncore,
+				           TRANS_PSR_IIR(dev_priv, trans),

-:32: ERROR:CODE_INDENT: code indent should use tabs where possible
#32: FILE: drivers/gpu/drm/i915/display/intel_display_irq.c:1464:
+^I^I^I^I           0xffffffff);$

total: 3 errors, 0 warnings, 2 checks, 44 lines checked
5f85b1c2a7a3 drm/i915: pass dev_priv explicitly to EDP_PSR_AUX_CTL
2d11442dc42f drm/i915: pass dev_priv explicitly to EDP_PSR_AUX_DATA
-:33: WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#33: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:99:
+#define EDP_PSR_AUX_DATA(dev_priv, tran, i)		_MMIO_TRANS2(dev_priv, tran, _SRD_AUX_DATA_A + (i) * 4) /* 5 registers */

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
7f136f40735b drm/i915: pass dev_priv explicitly to EDP_PSR_STATUS
76febc33beee drm/i915: pass dev_priv explicitly to EDP_PSR_PERF_CNT
-:33: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#33: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:129:
+#define EDP_PSR_PERF_CNT(dev_priv, tran)		_MMIO_TRANS2(dev_priv, tran, _SRD_PERF_CNT_A)

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
0a63d51cf987 drm/i915: pass dev_priv explicitly to EDP_PSR_DEBUG
42741c60ab7f drm/i915: pass dev_priv explicitly to EDP_PSR2_CTL
-:38: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#38: FILE: drivers/gpu/drm/i915/display/intel_psr.c:1703:
+		    intel_de_read(dev_priv, EDP_PSR2_CTL(dev_priv, cpu_transcoder)) & EDP_PSR2_ENABLE);

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
4a8d59d66433 drm/i915: pass dev_priv explicitly to PSR_EVENT
-:35: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#35: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:198:
+#define PSR_EVENT(dev_priv, tran)				_MMIO_TRANS2(dev_priv, tran, _PSR_EVENT_TRANS_A)

total: 0 errors, 1 warnings, 0 checks, 18 lines checked
2ba426ccfe37 drm/i915: pass dev_priv explicitly to EDP_PSR2_STATUS
8ef26fa40b7a drm/i915: pass dev_priv explicitly to _PSR2_SU_STATUS
-:21: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#21: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:224:
+#define _PSR2_SU_STATUS(dev_priv, tran, index)	_MMIO_TRANS2(dev_priv, tran, _PSR2_SU_STATUS_A + (index) * 4)

total: 0 errors, 1 warnings, 0 checks, 10 lines checked
9e6f8599023f drm/i915: pass dev_priv explicitly to PSR2_MAN_TRK_CTL
-:98: WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#98: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:232:
+#define PSR2_MAN_TRK_CTL(dev_priv, tran)					_MMIO_TRANS2(dev_priv, tran, _PSR2_MAN_TRK_CTL_A)

total: 0 errors, 1 warnings, 0 checks, 75 lines checked
f87911fe266b drm/i915: pass dev_priv explicitly to PIPE_SRCSZ_ERLY_TPT
-:46: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#46: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:252:
+#define PIPE_SRCSZ_ERLY_TPT(dev_priv, trans)	_MMIO_TRANS2(dev_priv, trans, _PIPE_SRCSZ_ERLY_TPT_A)

total: 0 errors, 1 warnings, 0 checks, 24 lines checked
e418b54f179f drm/i915: pass dev_priv explicitly to ALPM_CTL
fd717669b583 drm/i915: pass dev_priv explicitly to ALPM_CTL2
86fc46b1dacb drm/i915: pass dev_priv explicitly to PORT_ALPM_CTL
-:44: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#44: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:338:
+#define PORT_ALPM_CTL(dev_priv, tran)			_MMIO_TRANS2(dev_priv, tran, _PORT_ALPM_CTL_A)

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
545ca8b0ad8e drm/i915: pass dev_priv explicitly to PORT_ALPM_LFPS_CTL
-:34: WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#34: FILE: drivers/gpu/drm/i915/display/intel_psr_regs.h:348:
+#define PORT_ALPM_LFPS_CTL(dev_priv, tran)				_MMIO_TRANS2(dev_priv, tran, _PORT_ALPM_LFPS_CTL_A)

total: 0 errors, 1 warnings, 0 checks, 17 lines checked




More information about the Intel-gfx mailing list