[PATCH v3 01/21] drm/i915/psr: Add some documentation of variables used in psr code

[Manna, Animesh]

> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander at intel.com>
> Sent: Friday, January 19, 2024 3:40 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna at intel.com>; Hogander, Jouni
> <jouni.hogander at intel.com>
> Subject: [PATCH v3 01/21] drm/i915/psr: Add some documentation of
> variables used in psr code
> 
> We are adding more boolean variable into intel_psr and intel_crtc_state
> structs. Add some documentation about these for sake of clarity.
> 
> v2: Modify has_psr +  has_panel_replay to mean panel replay
> 
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>

LGTM.
Reviewed-by: Animesh Manna <animesh.manna at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 696d5d32ca9d..b9d2f6ceb568 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -171,6 +171,22 @@
>   *
>   * The rest of the bits are more self-explanatory and/or
>   * irrelevant for normal operation.
> + *
> + * Description of intel_crtc_state variables. has_psr, has_panel_replay
> + and
> + * has_sel_update:
> + *
> + *  has_psr (alone):					PSR1
> + *  has_psr + has_sel_update:				PSR2
> + *  has_psr + has_panel_replay:				Panel Replay
> + *  has_psr + has_panel_replay + has_sel_update:	Panel Replay Selective
> Update
> + *
> + * Description of some intel_psr varibles. enabled,
> + panel_replay_enabled,
> + * sel_update_enabled
> + *
> + *  enabled (alone):						PSR1
> + *  enabled + sel_update_enabled:				PSR2
> + *  enabled + panel_replay_enabled:				Panel Replay
> + *  enabled + panel_replay_enabled + sel_update_enabled:	Panel Replay
> SU
>   */
> 
>  #define CAN_PSR(intel_dp) ((intel_dp)->psr.sink_support && \
> --
> 2.34.1