[PATCH v3 12/16] drm/i915: Simplify intel_initial_plane_config() calling convention

[Jani Nikula]

On Fri, 02 Feb 2024, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Fri, Feb 02, 2024 at 05:14:37PM +0200, Jani Nikula wrote:
>> On Tue, 16 Jan 2024, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
>> So this fails to build on CONFIG_DRM_XE=m, because it has its own
>> version of intel_plane_initial.c which has
>> intel_crtc_initial_plane_config(), but not intel_initial_plane_config().
>> 
>> You'll get this as the first indication:
>> 
>>   CC [M]  drivers/gpu/drm/xe/display/xe_plane_initial.o
>> ../drivers/gpu/drm/xe/display/xe_plane_initial.c:270:6: error: no previous prototype for ‘intel_crtc_initial_plane_config’ [-Werror=missing-prototypes]
>>   270 | void intel_crtc_initial_plane_config(struct intel_crtc *crtc)
>>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> 
>> but if you bypass that, eventually:
>> 
>>   MODPOST Module.symvers
>> ERROR: modpost: "intel_initial_plane_config" [drivers/gpu/drm/xe/xe.ko] undefined!
>> 
>> Needs to be fixed before merging.
>
> Can't see anything off in the CI results. Are we not at
> least build testing xe in i915 CI?

We're not. It's a work in progress.

You can Cc: intel-xe mailing list to get both build and testing on
Xe. (Also a work in progress to use the same config and builds for
both. Now they're completely detached.)


BR,
Jani.


-- 
Jani Nikula, Intel