[PATCH] drm/i915/selftests: Increasing the sleep time for live_rc6_manual

Gupta, Anshuman anshuman.gupta at intel.com
Thu Feb 8 14:11:22 UTC 2024



> -----Original Message-----
> From: Anirban, Sk <sk.anirban at intel.com>
> Sent: Thursday, February 8, 2024 5:04 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Gupta, Anshuman <anshuman.gupta at intel.com>; Poosa, Karthik
> <karthik.poosa at intel.com>; Anirban, Sk <sk.anirban at intel.com>
> Subject: [PATCH] drm/i915/selftests: Increasing the sleep time for
> Sometimes gt_pm live_rc6_manual selftest fails due to no power being measure for 
Period for which rc6 was disabled. Therefore increase the rc6 disable period to 1000ms to
rule out such sporadic failure.
With that change.
Reviewed-by: Anshuman Gupta <anshuman.gupta at intel.com>
Br,
Anshuman
> 
> From: Anirban Sk <sk.anirban at intel.com>
> 
> To rule out the sporadic failure, updating the sleep time (time period to measure
> the power).
[Gupta, Anshuman] Please provide more descriptive commit log, something like below,
"gt_pm "
> 
> Signed-off-by: Anirban Sk <sk.anirban at intel.com>
> ---
>  drivers/gpu/drm/i915/gt/selftest_rc6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c
> b/drivers/gpu/drm/i915/gt/selftest_rc6.c
> index a7189c2d660c..1aa1446c8fb0 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c
> @@ -62,12 +62,12 @@ int live_rc6_manual(void *arg)
> 
>  	dt = ktime_get();
>  	rc0_power = librapl_energy_uJ();
> -	msleep(250);
> +	msleep(1000);
>  	rc0_power = librapl_energy_uJ() - rc0_power;
>  	dt = ktime_sub(ktime_get(), dt);
>  	res[1] = rc6_residency(rc6);
>  	if ((res[1] - res[0]) >> 10) {
> -		pr_err("RC6 residency increased by %lldus while disabled for
> 250ms!\n",
> +		pr_err("RC6 residency increased by %lldus while disabled for
> +1000ms!\n",
>  		       (res[1] - res[0]) >> 10);
>  		err = -EINVAL;
>  		goto out_unlock;
> --
> 2.25.1



More information about the Intel-gfx mailing list