[PATCH 4/5] drm/i915: Add PLL .compare_hw_state() vfunc

Jani Nikula jani.nikula at linux.intel.com
Wed Feb 14 18:03:48 UTC 2024


On Wed, 14 Feb 2024, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Wed, Feb 14, 2024 at 03:50:49PM +0200, Jani Nikula wrote:
>> As follow-up, would be great to see this move towards drm_printer based
>> approach, similar to pipe_config_dp_vsc_sdp_mismatch(). Reduces
>> duplication.
>
> Why did we convert just that single thing and not everything?

That change originated from me fixing drm_dp_vsc_sdp_log(), which was
quite horrible, to use drm_printer. So I just changed the drm side of
things, and haven't yet gotten around to fixing other things i915 side.

In fact 2e61504fd1c3 ("drm/dp: switch drm_dp_vsc_sdp_log() to struct
drm_printer") only exists in drm-misc-next, and we'll need that stuff
merged to drm-next and back to drm-intel-next.

BR,
Jani.

-- 
Jani Nikula, Intel


More information about the Intel-gfx mailing list