[PATCH 16/28] drm/i915/color: Create a transfer function color pipeline
Dan Carpenter
dan.carpenter at linaro.org
Mon Feb 19 07:34:49 UTC 2024
Hi Uma,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Uma-Shankar/drm-color-pipeline-base-work/20240213-144544
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20240213064835.139464-17-uma.shankar%40intel.com
patch subject: [PATCH 16/28] drm/i915/color: Create a transfer function color pipeline
config: i386-randconfig-141-20240217 (https://download.01.org/0day-ci/archive/20240218/202402180310.gMdIXaJx-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
| Closes: https://lore.kernel.org/r/202402180310.gMdIXaJx-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/i915/display/intel_color.c:3867 intel_plane_tf_pipeline_init() error: 'colorop' dereferencing possible ERR_PTR()
vim +/colorop +3867 drivers/gpu/drm/i915/display/intel_color.c
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3852 int intel_plane_tf_pipeline_init(struct drm_plane *plane, struct drm_prop_enum_list *list)
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3853 {
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3854 struct intel_plane *intel_plane = to_intel_plane(plane);
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3855 struct intel_plane_colorop *colorop;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3856 struct drm_device *dev = plane->dev;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3857 struct drm_i915_private *i915 = to_i915(dev);
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3858 int ret;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3859 struct drm_colorop *prev_op;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3860
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3861 colorop = intel_plane_colorop_create(CB_PLANE_PRE_CSC_LUT);
No error checking
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3862
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3863 ret = drm_colorop_init(dev, &colorop->base, plane, DRM_COLOROP_1D_LUT);
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3864 if (ret)
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3865 return ret;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3866
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 @3867 list->type = colorop->base.base.id;
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3868 list->name = kasprintf(GFP_KERNEL, "Color Pipeline %d", colorop->base.base.id);
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3869
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3870 /* TODO: handle failures and clean up*/
5e1e0f87c9bcae Chaitanya Kumar Borah 2024-02-13 3871 prev_op = &colorop->base;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the Intel-gfx
mailing list