✗ Fi.CI.CHECKPATCH: warning for QGV/SAGV related fixes (rev7)
Patchwork
patchwork at emeril.freedesktop.org
Tue Feb 20 11:55:19 UTC 2024
== Series Details ==
Series: QGV/SAGV related fixes (rev7)
URL : https://patchwork.freedesktop.org/series/126962/
State : warning
== Summary ==
Error: dim checkpatch failed
6011bbecc60e drm/i915: Add meaningful traces for QGV point info error handling
0521371d3ced drm/i915: Extract code required to calculate max qgv/psf gv point
7b57f933aefc drm/i915: Disable SAGV on bw init, to force QGV point recalculation
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12:
(i.e all points allowed), however in reality we might get them all restricted,
-:47: WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#47: FILE: drivers/gpu/drm/i915/display/intel_bw.c:165:
+ drm_err(&dev_priv->drm, "Failed to disable qgv points (%x) points: 0x%x\n", ret, points_mask);
-:89: CHECK:BRACES: braces {} should be used on all arms of this statement
#89: FILE: drivers/gpu/drm/i915/display/intel_bw.c:871:
+ if (max_data_rate > max_bw) {
[...]
+ } else if (max_data_rate == max_bw)
[...]
-:120: CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#120: FILE: drivers/gpu/drm/i915/display/intel_bw.c:902:
+ bw_state->qgv_points_mask = ~(ICL_PCODE_REQ_QGV_PT(qgv_points)|
^
-:133: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#133: FILE: drivers/gpu/drm/i915/display/intel_bw.c:915:
+
+}
total: 0 errors, 2 warnings, 3 checks, 123 lines checked
More information about the Intel-gfx
mailing list