✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev8)
Patchwork
patchwork at emeril.freedesktop.org
Wed Feb 21 23:18:30 UTC 2024
== Series Details ==
Series: Bigjoiner refactoring (rev8)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim checkpatch failed
99388805e7fa drm/i915/bigjoiner: Refactor bigjoiner state readout
1b4a23d5e363 Start separating pipe vs transcoder set logic for bigjoiner during modeset
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12:
That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave.
-:235: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#235: FILE: drivers/gpu/drm/i915/display/intel_display.c:1750:
+ * to change the workaround. */
-:361: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#361: FILE: drivers/gpu/drm/i915/display/intel_display.h:283:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \
+ list_for_each_entry_reverse(intel_crtc, \
+ &(dev)->mode_config.crtc_list, \
+ base.head) \
+ for_each_if((pipe_mask) & BIT(intel_crtc->pipe))
-:361: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_crtc' - possible side-effects?
#361: FILE: drivers/gpu/drm/i915/display/intel_display.h:283:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \
+ list_for_each_entry_reverse(intel_crtc, \
+ &(dev)->mode_config.crtc_list, \
+ base.head) \
+ for_each_if((pipe_mask) & BIT(intel_crtc->pipe))
total: 1 errors, 2 warnings, 1 checks, 317 lines checked
0ad1c861ceb6 drm/i915: Fix bigjoiner case for DP2.0
More information about the Intel-gfx
mailing list