[PATCH v1 5/6] drm/i915/xe2lpd: Load DMC
Gustavo Sousa
gustavo.sousa at intel.com
Thu Feb 22 20:39:53 UTC 2024
Quoting Lucas De Marchi (2024-02-22 11:26:57-03:00)
>On Thu, Feb 22, 2024 at 02:56:33PM +0200, Vinod Govindapillai wrote:
>>From: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
>>
>>Load DMC for XE2LPD. The value 0x8000 is the maximum payload size for
>>any xe2lpd dmc firmware.
>>
>>Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
>>Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane at intel.com>
>>---
>> drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>>diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
>>index 835781624482..54c5909de293 100644
>>--- a/drivers/gpu/drm/i915/display/intel_dmc.c
>>+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
>>@@ -89,10 +89,14 @@ static struct intel_dmc *i915_to_dmc(struct drm_i915_private *i915)
>> __stringify(major) "_" \
>> __stringify(minor) ".bin"
>>
>>+#define XE2LPD_MAX_FW_SIZE 0x8000
>> #define XELPDP_DMC_MAX_FW_SIZE 0x7000
>> #define DISPLAY_VER13_DMC_MAX_FW_SIZE 0x20000
>> #define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
>>
>>+#define XE2LPD_DMC_PATH DMC_PATH(xe2lpd)
>>+MODULE_FIRMWARE(XE2LPD_DMC_PATH);
>
>looking at the mailing list I don't see any pull request to either
>linux-firmware or drm-firmware with the DMC firmware. So if we had LNL
>in CI, it would just fail. We need it at least in drm-firmware to be
>able to test. We need it in linux-firmware to be able to merge.
FIY: Xe2LPD DMC has been merged into linux-firmware:
https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/160
--
Gustavo Sousa
More information about the Intel-gfx
mailing list