[PATCH 07/12] drm/i915: Use drm_printer more extensively in intel_crtc_state_dump()

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Feb 23 19:59:57 UTC 2024


On Thu, Feb 22, 2024 at 04:57:21PM -0500, Rodrigo Vivi wrote:
> On Thu, Feb 15, 2024 at 06:40:50PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Convert all the direct drm_dbg_kms() stuff in intel_crtc_state_dump()
> > over to drm_printf() since we now have the drm_printer around.
> 
> looking all this I ask myself if it is really a good idea
> to move from the debug helpers to the printf... we need
> to keep coming back to where the printer was defined to
> know what level we are printing...

The debug level is not really interesting at all. And it's
all the same anyway. 

Also we're going to need to go for the printer anyway if
we want to hook into the .atomic_state_print() stuff. And
at that point the printer will be provided by the caller.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list