✗ Fi.CI.CHECKPATCH: warning for Enable fastset for mbus_join state change

Patchwork patchwork at emeril.freedesktop.org
Wed Feb 28 08:45:13 UTC 2024


== Series Details ==

Series: Enable fastset for mbus_join state change
URL   : https://patchwork.freedesktop.org/series/130480/
State : warning

== Summary ==

Error: dim checkpatch failed
5d2ec76ef8f2 drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly
-:9: WARNING:TYPO_SPELLING: 'swithing' may be misspelled - perhaps 'switching'?
#9: 
or increasing amount of pipes(typical scenario is swithing between
                                                  ^^^^^^^^

-:12: WARNING:TYPO_SPELLING: 'swithing' may be misspelled - perhaps 'switching'?
#12: 
As of BSpec 49213 if we are swithing from multiple to single display
                            ^^^^^^^^

-:38: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_dbuf_state->active_pipes == 0'
#38: FILE: drivers/gpu/drm/i915/display/skl_watermark.c:3587:
+	if ((hweight8(new_dbuf_state->active_pipes) <= hweight8(old_dbuf_state->active_pipes))
+	    || (old_dbuf_state->active_pipes == 0))

-:39: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#39: FILE: drivers/gpu/drm/i915/display/skl_watermark.c:3588:
+	if ((hweight8(new_dbuf_state->active_pipes) <= hweight8(old_dbuf_state->active_pipes))
+	    || (old_dbuf_state->active_pipes == 0))

total: 0 errors, 2 warnings, 2 checks, 28 lines checked
763e4c15d36d drm/i915: Implement vblank synchronized MBUS join changes
-:24: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#24: 
v4: - Place "single display to multiple displays scenario" MBUS/DBOX programming

-:201: WARNING:LINE_SPACING: Missing a blank line after declarations
#201: FILE: drivers/gpu/drm/i915/display/skl_watermark.c:3653:
+		int i;
+		intel_dbuf_mbus_update(state);

-:212: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc->pipe != pipe'
#212: FILE: drivers/gpu/drm/i915/display/skl_watermark.c:3664:
+			if (!new_crtc_state->hw.active || (crtc->pipe != pipe))

total: 0 errors, 2 warnings, 1 checks, 211 lines checked




More information about the Intel-gfx mailing list