[PATCH v6 02/26] drm/i915/alpm: Write also AUX Less Wake lines into ALPM_CTL

Manna, Animesh animesh.manna at intel.com
Thu Jun 6 09:41:56 UTC 2024



> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander at intel.com>
> Sent: Wednesday, June 5, 2024 3:55 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna at intel.com>; Kahola, Mika
> <mika.kahola at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>
> Subject: [PATCH v6 02/26] drm/i915/alpm: Write also AUX Less Wake lines
> into ALPM_CTL
> 
> Currently AUX Less Wake lines are not written into ALPM_CTL. Fix this.
> 
> Fixes: 1ccbf135862b ("drm/i915/psr: Enable ALPM on source side for eDP
> Panel replay")
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>

Reviewed-by: Animesh Manna <animesh.manna at intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 52a573367976..18c1c5803670 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -323,7 +323,8 @@ static void lnl_alpm_configure(struct intel_dp
> *intel_dp,
>  	    (crtc_state->has_lobf &&
> intel_alpm_aux_less_wake_supported(intel_dp))) {
>  		alpm_ctl = ALPM_CTL_ALPM_ENABLE |
>  			ALPM_CTL_ALPM_AUX_LESS_ENABLE |
> -
> 	ALPM_CTL_AUX_LESS_SLEEP_HOLD_TIME_50_SYMBOLS;
> +
> 	ALPM_CTL_AUX_LESS_SLEEP_HOLD_TIME_50_SYMBOLS |
> +			ALPM_CTL_AUX_LESS_WAKE_TIME(intel_dp-
> >alpm_parameters.aux_less_wake_lines);
> 
>  		intel_de_write(dev_priv,
>  			       PORT_ALPM_CTL(dev_priv, cpu_transcoder),
> --
> 2.34.1



More information about the Intel-gfx mailing list