[PATCH 45/65] drm/i915: pass dev_priv explicitly to _DSPBSIZE
Rodrigo Vivi
rodrigo.vivi at intel.com
Thu Jun 6 16:09:41 UTC 2024
On Tue, Jun 04, 2024 at 06:26:03PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the _DSPBSIZE register macro.
>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 38c8b98d95c3..36ed23b93475 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2312,7 +2312,7 @@
> #define _DSPBADDR(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71184)
> #define _DSPBSTRIDE(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71188)
> #define _DSPBPOS(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x7118C)
> -#define _DSPBSIZE (DISPLAY_MMIO_BASE(dev_priv) + 0x71190)
> +#define _DSPBSIZE(dev_priv) (DISPLAY_MMIO_BASE(dev_priv) + 0x71190)
way too many unused cases...
we should probably remove them all in one patch and whoever is introducing them
later should already introduce with the dev_priv...
but again, up to you
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> #define _DSPBSURF (DISPLAY_MMIO_BASE(dev_priv) + 0x7119C)
> #define _DSPBTILEOFF (DISPLAY_MMIO_BASE(dev_priv) + 0x711A4)
> #define _DSPBOFFSET (DISPLAY_MMIO_BASE(dev_priv) + 0x711A4)
> --
> 2.39.2
>
More information about the Intel-gfx
mailing list