[PATCH v3 00/21] drm/i915/dp_mst: Enable link training fallback

Imre Deak imre.deak at intel.com
Mon Jun 10 16:49:12 UTC 2024


This is v3 of [1], addressing the review comments and adding R-bs from
Ville, the main changes being:

- Add the link check work to intel_encoder and the corresponding helper
  functions to a new intel_encoder.c file. (Patch 7)
- Add documentation/asserts on intel_atomic_state being valid for MST
  vs. possibly NULL for SST links in the link training functions.
  (Patch 9,10)
- Lock connection_mutex in the debugfs entries only for the required
  intel_dp state. (Patch 17-21)
- Remove the link training info debugfs entry showing the link retrain,
  link training failure counters and the retrain disabled state, add a
  separate debugfs entry showing only the retrain disabled state.
  (Patch 21)

[1] https://lore.kernel.org/all/20240520185822.3725844-1-imre.deak@intel.com

Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>

Imre Deak (21):
  drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs
  drm/i915/dp: Move link train params to a substruct in intel_dp
  drm/i915/dp: Move link train fallback to intel_dp_link_training.c
  drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()
  drm/i915: Factor out function to modeset commit a set of pipes
  drm/i915/dp: Use a commit modeset for link retraining MST links
  drm/i915/dp: Recheck link state after modeset
  drm/i915/dp: Reduce link params only after retrying with unchanged
    params
  drm/i915/dp: Pass atomic state to link training function
  drm/i915/dp: Send a link training modeset-retry uevent to all MST
    connectors
  drm/i915/dp: Use check link state work in the hotplug handler
  drm/i915/dp: Use check link state work in the detect handler
  drm/i915/dp: Use check link state work in the HPD IRQ handler
  drm/i915/dp: Disable link retraining after the last fallback step
  drm/i915/dp_mst: Reset intel_dp->link_trained during disabling
  drm/i915/dp_mst: Enable link training fallback for MST
  drm/i915/dp: Add debugfs entries to force the link rate/lane count
  drm/i915/dp: Add debugfs entries to get the max link rate/lane count
  drm/i915/dp: Add debugfs entry to force link training failure
  drm/i915/dp: Add debugfs entry to force link retrain
  drm/i915/dp: Add debugfs entry to get the link retrain disabled state

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/g4x_dp.c         |  35 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  67 +--
 drivers/gpu/drm/i915/display/intel_display.c  |  34 ++
 drivers/gpu/drm/i915/display/intel_display.h  |   3 +
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_types.h    |  25 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 270 +++++----
 drivers/gpu/drm/i915/display/intel_dp.h       |  11 +-
 .../drm/i915/display/intel_dp_link_training.c | 538 +++++++++++++++++-
 .../drm/i915/display/intel_dp_link_training.h |   8 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  30 +-
 drivers/gpu/drm/i915/display/intel_encoder.c  |  39 ++
 drivers/gpu/drm/i915/display/intel_encoder.h  |  16 +
 drivers/gpu/drm/xe/Makefile                   |   1 +
 15 files changed, 878 insertions(+), 202 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.h

-- 
2.43.3



More information about the Intel-gfx mailing list