[PATCH v8 04/20] drm/i915/psr: Add Panel Replay compute_config helper

[Manna, Animesh]

> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander at intel.com>
> Sent: Thursday, June 13, 2024 3:02 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna at intel.com>; Kahola, Mika
> <mika.kahola at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>
> Subject: [PATCH v8 04/20] drm/i915/psr: Add Panel Replay compute_config
> helper
> 
> We are about to add more checks for Panel Replay. Due to that it makes
> sense to add now Panel Replay compute config helper.
> 
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 44144dcfb1a3..f8e746e476e9 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1455,6 +1455,14 @@ static bool _psr_compute_config(struct intel_dp
> *intel_dp,
>  	return true;
>  }
> 
> +static bool _panel_replay_compute_config(struct intel_dp *intel_dp) {
> +	if (!CAN_PANEL_REPLAY(intel_dp))
> +		return false;
> +
> +	return true;
> +}
> +
>  void intel_psr_compute_config(struct intel_dp *intel_dp,
>  			      struct intel_crtc_state *crtc_state,
>  			      struct drm_connector_state *conn_state) @@ -
> 1490,8 +1498,7 @@ void intel_psr_compute_config(struct intel_dp
> *intel_dp,
>  		return;
>  	}
> 
> -	if (CAN_PANEL_REPLAY(intel_dp))
> -		crtc_state->has_panel_replay = true;
> +	crtc_state->has_panel_replay =
> _panel_replay_compute_config(intel_dp);

Maybe good to squash this patch with the patch where more checks are added in _panel_replay_compute_config.

Regards,
Animesh
> 
>  	crtc_state->has_psr = crtc_state->has_panel_replay ? true :
>  		_psr_compute_config(intel_dp, crtc_state);
> --
> 2.34.1