[PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64

Kandpal, Suraj suraj.kandpal at intel.com
Mon Jun 24 10:07:55 UTC 2024



> -----Original Message-----
> From: Golani, Mitulkumar Ajitkumar
> <mitulkumar.ajitkumar.golani at intel.com>
> Sent: Friday, June 21, 2024 1:05 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: intel-xe at lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi at intel.com>;
> jani.nikula at linux.intel.com; Kandpal, Suraj <suraj.kandpal at intel.com>;
> Nautiyal, Ankit K <ankit.k.nautiyal at intel.com>; nathan at kernel.org
> Subject: [PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64
> 
> Consider adjusted_pixel_rate to be a u64 to match the return type of
> mul_u32_u32() and avoid any compiler dependency for do_div.
> 
> Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal")
> Cc: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Suraj Kandpal <suraj.kandpal at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Nathan Chancellor <nathan at kernel.org>
> Cc: intel-xe at lists.freedesktop.org
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>

Thanks for the patches and reviews
Pushed to drm-intel-next

Regards,
Suraj Kandpal
> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c
> b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 6430da25957d..5a0da64c7db3 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -137,7 +137,7 @@ static unsigned int
>  cmrr_get_vtotal(struct intel_crtc_state *crtc_state, bool
> video_mode_required)  {
>  	int multiplier_m = 1, multiplier_n = 1, vtotal, desired_refresh_rate;
> -	long long adjusted_pixel_rate;
> +	u64 adjusted_pixel_rate;
>  	struct drm_display_mode *adjusted_mode = &crtc_state-
> >hw.adjusted_mode;
> 
>  	desired_refresh_rate = drm_mode_vrefresh(adjusted_mode);
> --
> 2.45.2



More information about the Intel-gfx mailing list