[PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Mar 1 16:15:51 UTC 2024


On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote:
>  	/*
>  	 * We need to disable pipe CRC before disabling the pipe,
>  	 * or we race against vblank off.
>  	 */
> -	intel_crtc_disable_pipe_crc(crtc);
> +	for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc, pipe_mask)
> +		intel_crtc_disable_pipe_crc(crtc);

Oh, and the pipe crc stuff is one thing we probably should spend some
brain cells on. The pfit/plane CRCs are per-pipe, so we should either
handle it in igt somehow, or we need come up with some kind of scheme
to combine the CRCs from all the joined pipes in the kernel so that
userspace doesn't have to deal with them.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list