✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev5)
Patchwork
patchwork at emeril.freedesktop.org
Wed Mar 6 04:11:56 UTC 2024
== Series Details ==
Series: Disable automatic load CCS load balancing (rev5)
URL : https://patchwork.freedesktop.org/series/129951/
State : warning
== Summary ==
Error: dim checkpatch failed
5b93f1cd8989 drm/i915/gt: Disable HW load balancing for CCS
380b317702a8 drm/i915/gt: Refactor uabi engine class/instance list creation
-:55: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#55: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:233:
+ GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance));
-:71: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#71: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:247:
+ GEM_BUG_ON(uabi_class >=
total: 0 errors, 2 warnings, 0 checks, 56 lines checked
4cdfe2cf85b2 drm/i915/gt: Enable only one CCS for compute workload
-:16: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#16:
Requires: 97aba5e46038 ("drm/i915/gt: Refactor uabi engine class/instance list creation")
-:104: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cslice' may be better as '(cslice)' to avoid precedence issues
#104: FILE: drivers/gpu/drm/i915/gt/intel_gt_regs.h:1486:
+#define XEHP_CCS_MODE_CSLICE(cslice, ccs) (ccs << (cslice * XEHP_CCS_MODE_CSLICE_WIDTH))
-:104: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ccs' may be better as '(ccs)' to avoid precedence issues
#104: FILE: drivers/gpu/drm/i915/gt/intel_gt_regs.h:1486:
+#define XEHP_CCS_MODE_CSLICE(cslice, ccs) (ccs << (cslice * XEHP_CCS_MODE_CSLICE_WIDTH))
total: 0 errors, 1 warnings, 2 checks, 69 lines checked
More information about the Intel-gfx
mailing list