✗ Fi.CI.CHECKPATCH: warning for drm/i915: better high level abstraction for display

[Patchwork]

== Series Details ==

Series: drm/i915: better high level abstraction for display
URL   : https://patchwork.freedesktop.org/series/130805/
State : warning

== Summary ==

Error: dim checkpatch failed
3000e528f9db drm/i915/display: ideas for further separating display code from the rest
ffc3bd209f4c drm/i915/display: add generic to_intel_display() macro
-:58: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#58: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2218:
+	struct type: __##type##_to_intel_display((struct type *)(p))
 	           ^

-:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#61: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2221:
+#define to_intel_display(p)				\
+	_Generic(*p,					\
+		 __assoc(intel_connector, p),		\
+		 __assoc(intel_crtc, p),		\
+		 __assoc(intel_crtc_state, p),		\
+		 __assoc(intel_digital_port, p),	\
+		 __assoc(intel_encoder, p),		\
+		 __assoc(intel_hdmi, p),		\
+		 __assoc(intel_dp, p),			\
+		 __assoc(drm_device, p))

-:61: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'p' may be better as '(p)' to avoid precedence issues
#61: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2221:
+#define to_intel_display(p)				\
+	_Generic(*p,					\
+		 __assoc(intel_connector, p),		\
+		 __assoc(intel_crtc, p),		\
+		 __assoc(intel_crtc_state, p),		\
+		 __assoc(intel_digital_port, p),	\
+		 __assoc(intel_encoder, p),		\
+		 __assoc(intel_hdmi, p),		\
+		 __assoc(intel_dp, p),			\
+		 __assoc(drm_device, p))

-:62: CHECK:CAMELCASE: Avoid CamelCase: <_Generic>
#62: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2222:
+	_Generic(*p,					\

total: 1 errors, 0 warnings, 3 checks, 50 lines checked
d58449dd142d drm/i915/display: accept either i915 or display for feature tests
-:21: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915_or_display' - possible side-effects?
#21: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:17:
+#define __display(i915_or_display)					\
+	_Generic(*i915_or_display,					\
+		 struct drm_i915_private: (((const struct drm_i915_private *)(i915_or_display))->__intel_display_private), \
+		 struct intel_display: (i915_or_display))

-:21: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i915_or_display' may be better as '(i915_or_display)' to avoid precedence issues
#21: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:17:
+#define __display(i915_or_display)					\
+	_Generic(*i915_or_display,					\
+		 struct drm_i915_private: (((const struct drm_i915_private *)(i915_or_display))->__intel_display_private), \
+		 struct intel_display: (i915_or_display))

-:22: CHECK:CAMELCASE: Avoid CamelCase: <_Generic>
#22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18:
+	_Generic(*i915_or_display,					\

-:23: WARNING:LONG_LINE: line length of 124 exceeds 100 columns
#23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:19:
+		 struct drm_i915_private: (((const struct drm_i915_private *)(i915_or_display))->__intel_display_private), \

-:23: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:19:
+		 struct drm_i915_private: (((const struct drm_i915_private *)(i915_or_display))->__intel_display_private), \
 		                        ^

-:24: ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#24: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:20:
+		 struct intel_display: (i915_or_display))
 		                     ^

total: 2 errors, 1 warnings, 3 checks, 22 lines checked
86ad59f094bd drm/i915/display: test various to_intel_display() scenarios