✗ Fi.CI.CHECKPATCH: warning for Introduce drm sharpening property (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 7 10:49:21 UTC 2024


== Series Details ==

Series: Introduce drm sharpening property (rev2)
URL   : https://patchwork.freedesktop.org/series/129888/
State : warning

== Summary ==

Error: dim checkpatch failed
4fe845215e02 drm: Introduce sharpness mode property
65b8e0c3c5e8 drm/i915/display: Compute the scaler filter coefficients
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:74: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

-:196: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#196: FILE: drivers/gpu/drm/i915/display/intel_sharpen_filter.c:118:
+				SHARP_COEFF_TO_REG_FORMAT(crtc_state->hw.casf_params.coeff[tapindex]);

-:216: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'coefficient' - possible side-effects?
#216: FILE: drivers/gpu/drm/i915/display/intel_sharpen_filter.h:11:
+#define SHARP_COEFF_TO_REG_FORMAT(coefficient) ((u16)(coefficient.sign << 15 | \
+			coefficient.exp << 12 | coefficient.mantissa << 3))

total: 0 errors, 2 warnings, 1 checks, 206 lines checked
34a37b8966c7 drm/i915/display: Enable the second scaler
-:198: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#198: FILE: drivers/gpu/drm/i915/display/skl_scaler.c:747:
+	x = y = 0;

total: 0 errors, 0 warnings, 1 checks, 204 lines checked
7f7464e052b9 drm/i915/display: Add registers and compute the strength
51c9a73ff22c drm/i915/display: Load the lut values and enable sharpness




More information about the Intel-gfx mailing list