✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: DMC wakelock implementation

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 14 08:38:22 UTC 2024


== Series Details ==

Series: drm/i915/display: DMC wakelock implementation
URL   : https://patchwork.freedesktop.org/series/131124/
State : warning

== Summary ==

Error: dim checkpatch failed
80db5bb4bd35 drm/i915/display: add support for DMC wakelocks
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:237: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#237: 
new file mode 100644

-:242: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_dmc_wl.c', please use '//' instead
#242: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:242: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#242: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:1:
+/* SPDX-License-Identifier: MIT */

-:381: WARNING:RETURN_VOID: void function return statements are not generally useful
#381: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:140:
+	return;
+}

-:410: WARNING:RETURN_VOID: void function return statements are not generally useful
#410: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:169:
+	return;
+}

-:458: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#458: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.c:217:
+	if (WARN_RATELIMIT(!refcount_read(&wl->refcount),
+		    "Tried to put wakelock with refcount zero\n"))

-:493: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#493: FILE: drivers/gpu/drm/i915/display/intel_dmc_wl.h:18:
+	spinlock_t lock;

total: 0 errors, 5 warnings, 2 checks, 452 lines checked
6aad00635acd drm/i915/display: don't allow DMC wakelock on older hardware
60597a92ce84 drm/i915/display: add module parameter to enable DMC wakelock
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display_params.c:120:
+intel_display_param_named_unsafe(enable_dmc_wl, bool, 0400,
+	"Enable DMC wakelock "

total: 0 errors, 0 warnings, 1 checks, 54 lines checked
971e6ab0cf23 drm/i915/display: tie DMC wakelock to DC5/6 state transitions




More information about the Intel-gfx mailing list