✗ Fi.CI.CHECKPATCH: warning for Bigjoiner refactoring (rev13)
Patchwork
patchwork at emeril.freedesktop.org
Tue Mar 19 16:00:02 UTC 2024
== Series Details ==
Series: Bigjoiner refactoring (rev13)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim checkpatch failed
999dde986c7d drm/i915: Add a small helper to compute the set of pipes for crtc
6cbe4e0e2f3e drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()
-:77: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#77: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3136:
+{
+
total: 0 errors, 0 warnings, 1 checks, 57 lines checked
9cb9a8701ff1 drm/i915: Utilize intel_crtc_joined_pipe_mask() more
48d5877ce2c4 drm/i915: Handle joined pipes inside hsw_crtc_disable()
-:130: ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: drivers/gpu/drm/i915/display/intel_display.c:6819:
+ if (intel_crtc_is_bigjoiner_slave(old_crtc_state))$
-:130: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#130: FILE: drivers/gpu/drm/i915/display/intel_display.c:6819:
+ if (intel_crtc_is_bigjoiner_slave(old_crtc_state))$
-:131: ERROR:CODE_INDENT: code indent should use tabs where possible
#131: FILE: drivers/gpu/drm/i915/display/intel_display.c:6820:
+ continue;$
-:131: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#131: FILE: drivers/gpu/drm/i915/display/intel_display.c:6820:
+ continue;$
total: 2 errors, 2 warnings, 0 checks, 111 lines checked
29738fb9d7e0 drm/i915: Handle joined pipes inside hsw_crtc_enable()
-:8: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#8:
That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave.
-:278: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#278: FILE: drivers/gpu/drm/i915/display/intel_display.c:1718:
+ * to change the workaround. */
-:331: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#331: FILE: drivers/gpu/drm/i915/display/intel_display.h:315:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \
+ list_for_each_entry_reverse(intel_crtc, \
+ &(dev)->mode_config.crtc_list, \
+ base.head) \
+ for_each_if((pipe_mask) & BIT(intel_crtc->pipe))
-:331: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_crtc' - possible side-effects?
#331: FILE: drivers/gpu/drm/i915/display/intel_display.h:315:
+#define for_each_intel_crtc_in_pipe_mask_reverse(dev, intel_crtc, pipe_mask) \
+ list_for_each_entry_reverse(intel_crtc, \
+ &(dev)->mode_config.crtc_list, \
+ base.head) \
+ for_each_if((pipe_mask) & BIT(intel_crtc->pipe))
total: 1 errors, 2 warnings, 1 checks, 304 lines checked
9c75440ef274 drm/i915: Allow bigjoiner for MST
More information about the Intel-gfx
mailing list