✗ Fi.CI.CHECKPATCH: warning for drm/i915/pciids: PCI ID macro cleanups

Patchwork patchwork at emeril.freedesktop.org
Fri May 10 13:09:02 UTC 2024 

== Series Details ==

Series: drm/i915/pciids: PCI ID macro cleanups
URL   : https://patchwork.freedesktop.org/series/133444/
State : warning

== Summary ==

Error: dim checkpatch failed
74c4a4b08b9b drm/i915/pciids: add INTEL_PNV_IDS(), use acronym
-:72: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#72: FILE: include/drm/i915_pciids.h:117:
+#define INTEL_PNV_IDS(info) \
+	INTEL_PNV_G_IDS(info), \
+	INTEL_PNV_M_IDS(info)

-:72: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#72: FILE: include/drm/i915_pciids.h:117:
+#define INTEL_PNV_IDS(info) \
+	INTEL_PNV_G_IDS(info), \
+	INTEL_PNV_M_IDS(info)

total: 1 errors, 0 warnings, 1 checks, 46 lines checked
ec59b5b635f2 drm/i915/pciids: add INTEL_ILK_IDS(), use acronym
-:73: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#73: FILE: include/drm/i915_pciids.h:127:
+#define INTEL_ILK_IDS(info) \
+	INTEL_ILK_D_IDS(info), \
+	INTEL_ILK_M_IDS(info)

-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#73: FILE: include/drm/i915_pciids.h:127:
+#define INTEL_ILK_IDS(info) \
+	INTEL_ILK_D_IDS(info), \
+	INTEL_ILK_M_IDS(info)

total: 1 errors, 0 warnings, 1 checks, 47 lines checked
36178b28f831 drm/i915/pciids: add INTEL_SNB_IDS()
-:48: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#48: FILE: include/drm/i915_pciids.h:154:
+#define INTEL_SNB_IDS(info) \
+	INTEL_SNB_D_IDS(info), \
+	INTEL_SNB_M_IDS(info)

-:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#48: FILE: include/drm/i915_pciids.h:154:
+#define INTEL_SNB_IDS(info) \
+	INTEL_SNB_D_IDS(info), \
+	INTEL_SNB_M_IDS(info)

total: 1 errors, 0 warnings, 1 checks, 28 lines checked
05d3be80584d drm/i915/pciids: add INTEL_IVB_IDS()
-:48: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#48: FILE: include/drm/i915_pciids.h:180:
+#define INTEL_IVB_IDS(info) \
+	INTEL_IVB_M_IDS(info), \
+	INTEL_IVB_D_IDS(info)

-:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#48: FILE: include/drm/i915_pciids.h:180:
+#define INTEL_IVB_IDS(info) \
+	INTEL_IVB_M_IDS(info), \
+	INTEL_IVB_D_IDS(info)

total: 1 errors, 0 warnings, 1 checks, 28 lines checked
b960793f2bf0 drm/i915/pciids: don't include WHL/CML PCI IDs in CFL
-:56: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#56: FILE: include/drm/i915_pciids.h:491:
+#define INTEL_CML_IDS(info) \
+	INTEL_CML_GT1_IDS(info), \
+	INTEL_CML_GT2_IDS(info), \
+	INTEL_CML_U_GT1_IDS(info), \
+	INTEL_CML_U_GT2_IDS(info)

-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#56: FILE: include/drm/i915_pciids.h:491:
+#define INTEL_CML_IDS(info) \
+	INTEL_CML_GT1_IDS(info), \
+	INTEL_CML_GT2_IDS(info), \
+	INTEL_CML_U_GT1_IDS(info), \
+	INTEL_CML_U_GT2_IDS(info)

-:69: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#69: FILE: include/drm/i915_pciids.h:536:
+#define INTEL_CFL_IDS(info)	   \
+	INTEL_CFL_S_GT1_IDS(info), \
+	INTEL_CFL_S_GT2_IDS(info), \
+	INTEL_CFL_H_GT1_IDS(info), \
+	INTEL_CFL_H_GT2_IDS(info), \
+	INTEL_CFL_U_GT2_IDS(info), \
+	INTEL_CFL_U_GT3_IDS(info), \
+	INTEL_AML_CFL_GT2_IDS(info)

-:69: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#69: FILE: include/drm/i915_pciids.h:536:
+#define INTEL_CFL_IDS(info)	   \
+	INTEL_CFL_S_GT1_IDS(info), \
+	INTEL_CFL_S_GT2_IDS(info), \
+	INTEL_CFL_H_GT1_IDS(info), \
+	INTEL_CFL_H_GT2_IDS(info), \
+	INTEL_CFL_U_GT2_IDS(info), \
+	INTEL_CFL_U_GT3_IDS(info), \
+	INTEL_AML_CFL_GT2_IDS(info)

-:92: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#92: FILE: include/drm/i915_pciids.h:559:
+#define INTEL_WHL_IDS(info) \
 	INTEL_WHL_U_GT1_IDS(info), \
 	INTEL_WHL_U_GT2_IDS(info), \
+	INTEL_WHL_U_GT3_IDS(info)

-:92: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#92: FILE: include/drm/i915_pciids.h:559:
+#define INTEL_WHL_IDS(info) \
 	INTEL_WHL_U_GT1_IDS(info), \
 	INTEL_WHL_U_GT2_IDS(info), \
+	INTEL_WHL_U_GT3_IDS(info)

total: 3 errors, 0 warnings, 3 checks, 66 lines checked
765c60a9fc28 drm/i915/pciids: remove 11 from INTEL_ICL_IDS()
-:61: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#61: FILE: include/drm/i915_pciids.h:600:
+#define INTEL_ICL_IDS(info) \
 	INTEL_ICL_PORT_F_IDS(info), \
 	INTEL_VGA_DEVICE(0x8A51, info), \
 	INTEL_VGA_DEVICE(0x8A5D, info)

-:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#61: FILE: include/drm/i915_pciids.h:600:
+#define INTEL_ICL_IDS(info) \
 	INTEL_ICL_PORT_F_IDS(info), \
 	INTEL_VGA_DEVICE(0x8A51, info), \
 	INTEL_VGA_DEVICE(0x8A5D, info)

total: 1 errors, 0 warnings, 1 checks, 32 lines checked
e9739817685c drm/i915/pciids: remove 12 from INTEL_TGL_IDS()
-:74: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#74: FILE: include/drm/i915_pciids.h:623:
+#define INTEL_TGL_GT1_IDS(info) \
 	INTEL_VGA_DEVICE(0x9A60, info), \
 	INTEL_VGA_DEVICE(0x9A68, info), \
 	INTEL_VGA_DEVICE(0x9A70, info)

-:74: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#74: FILE: include/drm/i915_pciids.h:623:
+#define INTEL_TGL_GT1_IDS(info) \
 	INTEL_VGA_DEVICE(0x9A60, info), \
 	INTEL_VGA_DEVICE(0x9A68, info), \
 	INTEL_VGA_DEVICE(0x9A70, info)

-:80: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#80: FILE: include/drm/i915_pciids.h:628:
+#define INTEL_TGL_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x9A40, info), \
 	INTEL_VGA_DEVICE(0x9A49, info), \
 	INTEL_VGA_DEVICE(0x9A59, info), \

-:80: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#80: FILE: include/drm/i915_pciids.h:628:
+#define INTEL_TGL_GT2_IDS(info) \
 	INTEL_VGA_DEVICE(0x9A40, info), \
 	INTEL_VGA_DEVICE(0x9A49, info), \
 	INTEL_VGA_DEVICE(0x9A59, info), \

-:91: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#91: FILE: include/drm/i915_pciids.h:638:
+#define INTEL_TGL_IDS(info) \
+	INTEL_TGL_GT1_IDS(info), \
+	INTEL_TGL_GT2_IDS(info)

-:91: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#91: FILE: include/drm/i915_pciids.h:638:
+#define INTEL_TGL_IDS(info) \
+	INTEL_TGL_GT1_IDS(info), \
+	INTEL_TGL_GT2_IDS(info)

total: 3 errors, 0 warnings, 3 checks, 58 lines checked
18218e6b0d87 drm/i915/pciids: don't include RPL-U PCI IDs in RPL-P

More information about the Intel-gfx mailing list