[PATCH 02/13] drm/i915: Clean up the cursor register defines

Jani Nikula jani.nikula at linux.intel.com
Mon May 20 16:34:03 UTC 2024


On Mon, 20 May 2024, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Mon, May 20, 2024 at 12:10:30PM +0300, Jani Nikula wrote:
>> On Thu, 16 May 2024, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
>> I also think it's kind of unnecessary when they're only
>> passed on as parameters. Or is there some corner case where it matters?
>
> I think cargo-culting is probably the best argument for protecting
> each and every macro argument. If used universally then I think
> it'll be a bit more likely that newly added macros, where it
> might matter more, will inherit it as well.

That's a good point.

BR,
Jani.


-- 
Jani Nikula, Intel


More information about the Intel-gfx mailing list