✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Add comparison for pipe config for MTL+ >

Patchwork patchwork at emeril.freedesktop.org
Thu May 23 15:34:32 UTC 2024


== Series Details ==

Series: drm/i915/display: Add comparison for pipe config for MTL+ >
URL   : https://patchwork.freedesktop.org/series/133968/
State : warning

== Summary ==

Error: dim checkpatch failed
840f16a219ec drm/i915/display: Revert "drm/i915/display: Skip C10 state verification in case of fastset"
7fe52b8d3995 drm/i915/display: Add compare config for MTL+ platforms
-:133: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#133: FILE: drivers/gpu/drm/i915/display/intel_cx0_phy.c:3328:
+{
+

-:208: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#208: FILE: drivers/gpu/drm/i915/display/intel_display.c:5128:
+#define PIPE_CONF_CHECK_PLL_CX0(name) do { \
+	if (!intel_cx0pll_compare_hw_state(&current_config->name, \
+					   &pipe_config->name)) { \
+		pipe_config_cx0pll_mismatch(&p, fastset, crtc, __stringify(name), \
+					    &current_config->name, \
+					    &pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

-:208: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#208: FILE: drivers/gpu/drm/i915/display/intel_display.c:5128:
+#define PIPE_CONF_CHECK_PLL_CX0(name) do { \
+	if (!intel_cx0pll_compare_hw_state(&current_config->name, \
+					   &pipe_config->name)) { \
+		pipe_config_cx0pll_mismatch(&p, fastset, crtc, __stringify(name), \
+					    &current_config->name, \
+					    &pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

total: 0 errors, 0 warnings, 3 checks, 195 lines checked




More information about the Intel-gfx mailing list