✗ Fi.CI.CHECKPATCH: warning for Implement CMRR Support (rev9)

Patchwork patchwork at emeril.freedesktop.org
Fri May 24 11:02:26 UTC 2024


== Series Details ==

Series: Implement CMRR Support (rev9)
URL   : https://patchwork.freedesktop.org/series/126443/
State : warning

== Summary ==

Error: dim checkpatch failed
569f89bc8d2a drm/i915: Define and compute Transcoder CMRR registers
-:48: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#48: FILE: drivers/gpu/drm/i915/display/intel_display.c:5064:
+#define PIPE_CONF_CHECK_LLI(name) do { \
+	if (current_config->name != pipe_config->name) { \
+		pipe_config_mismatch(&p, fastset, crtc, __stringify(name), \
+				     "(expected %lli, found %lli)", \
+				     current_config->name, \
+				     pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

-:48: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#48: FILE: drivers/gpu/drm/i915/display/intel_display.c:5064:
+#define PIPE_CONF_CHECK_LLI(name) do { \
+	if (current_config->name != pipe_config->name) { \
+		pipe_config_mismatch(&p, fastset, crtc, __stringify(name), \
+				     "(expected %lli, found %lli)", \
+				     current_config->name, \
+				     pipe_config->name); \
+		ret = false; \
+	} \
+} while (0)

-:151: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#151: 
new file mode 100644

total: 0 errors, 1 warnings, 2 checks, 125 lines checked
223571376cf9 drm/i915: Update trans_vrr_ctl flag when cmrr is computed
78f31fa1463a drm/i915: Compute CMRR and calculate vtotal
de5c66dca679 Add refresh rate divider to struct representing AS SDP
493d5b49771f drm/i915/display: Add support for pack and unpack
7309d5ca1a2a drm/i915/display: Compute Adaptive sync SDP params
242a0f1a8d69 drm/i915/display: Compute vrr vsync params
e0bae01b231a drm/i915/display: Compute cmrr.enable flag




More information about the Intel-gfx mailing list