[PATCH 4/4] drm/i915/pmu: Remove pointless synchronize_rcu() call
Lucas De Marchi
lucas.demarchi at intel.com
Mon Nov 4 21:35:12 UTC 2024
This is already done inside perf_pmu_unregister() - no need to do it
before.
Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
drivers/gpu/drm/i915/i915_pmu.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index bd476297ed0a1..e55db036be1bb 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -1335,13 +1335,8 @@ void i915_pmu_unregister(struct drm_i915_private *i915)
if (!pmu->registered)
return;
- /*
- * "Disconnect" the PMU callbacks - since all are atomic synchronize_rcu
- * ensures all currently executing ones will have exited before we
- * proceed with unregistration.
- */
+ /* Disconnect the PMU callbacks */
pmu->registered = false;
- synchronize_rcu();
hrtimer_cancel(&pmu->timer);
--
2.47.0
More information about the Intel-gfx
mailing list