✗ Fi.CI.CHECKPATCH: warning for drm/i915/pps: Some PPS cleanups
Patchwork
patchwork at emeril.freedesktop.org
Wed Nov 6 22:44:20 UTC 2024
== Series Details ==
Series: drm/i915/pps: Some PPS cleanups
URL : https://patchwork.freedesktop.org/series/141029/
State : warning
== Summary ==
Error: dim checkpatch failed
7be5d99fa0f8 drm/i915/pps: Store the power cycle delay without the +1
6688c47ffde8 drm/i915/pps: Decouple pps delays from VBT struct definition
3b1a3739c305 drm/i915/pps: Rename intel_pps_delay members
-:68: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#68: FILE: drivers/gpu/drm/i915/display/intel_pps.c:679:
+ * and then make panel wait for power_cycle if needed. */
total: 0 errors, 1 warnings, 0 checks, 209 lines checked
3c6329bdd2a4 drm/i915/lvds: Use struct intel_pps_delays for LVDS power sequencing
316a476b0eb7 drm/i915/pps: Spell out the eDP spec power sequencing delays a bit more clearly
9e592e1b132e drm/i915/pps: Extract msecs_to_pps_units()
-:54: WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns
#54: FILE: drivers/gpu/drm/i915/display/intel_pps.c:1522:
+ spec->backlight_off = msecs_to_pps_units(50); /* no limit for T9, make it symmetric with T8 */
total: 0 errors, 1 warnings, 0 checks, 47 lines checked
e9122d84c242 drm/i915/pps: Extract pps_units_to_msecs()
-:35: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'field' may be better as '(field)' to avoid precedence issues
#35: FILE: drivers/gpu/drm/i915/display/intel_pps.c:1563:
+#define get_delay(field) pps_units_to_msecs(final->field)
total: 0 errors, 0 warnings, 1 checks, 20 lines checked
287e4f222a03 drm/i915/pps: Eliminate pointless get_delay() macro
More information about the Intel-gfx
mailing list