✗ Fi.CI.CHECKPATCH: warning for drm/i915/pps: Some PPS cleanups (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Thu Nov 7 16:15:57 UTC 2024
== Series Details ==
Series: drm/i915/pps: Some PPS cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/141029/
State : warning
== Summary ==
Error: dim checkpatch failed
ff7d1dd11395 drm/i915/pps: Store the power cycle delay without the +1
fc8b358de349 drm/i915/pps: Decouple pps delays from VBT struct definition
f31f677dab2f drm/i915/pps: Rename intel_pps_delay members
-:69: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#69: FILE: drivers/gpu/drm/i915/display/intel_pps.c:679:
+ * and then make panel wait for power_cycle if needed. */
total: 0 errors, 1 warnings, 0 checks, 209 lines checked
127aa6788808 drm/i915/lvds: Use struct intel_pps_delays for LVDS power sequencing
8b6c82f420f9 drm/i915/pps: Spell out the eDP spec power sequencing delays a bit more clearly
7a77e96187ed drm/i915/pps: Extract msecs_to_pps_units()
-:55: WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns
#55: FILE: drivers/gpu/drm/i915/display/intel_pps.c:1522:
+ spec->backlight_off = msecs_to_pps_units(50); /* no limit for T9, make it symmetric with T8 */
total: 0 errors, 1 warnings, 0 checks, 47 lines checked
d267e5a36046 drm/i915/pps: Extract pps_units_to_msecs()
-:36: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'field' may be better as '(field)' to avoid precedence issues
#36: FILE: drivers/gpu/drm/i915/display/intel_pps.c:1563:
+#define get_delay(field) pps_units_to_msecs(final->field)
total: 0 errors, 0 warnings, 1 checks, 20 lines checked
9be03212247a drm/i915/pps: Eliminate pointless get_delay() macro
More information about the Intel-gfx
mailing list