[PATCH 4/9] drm/i915/display: update logic to determine crtcstate has audio support

[Kai Vehmanen]

Hi,

On Tue, 8 Oct 2024, Vinod Govindapillai wrote:

> In intel_dp_audio_compute_config() pipe_config->has_audio decision
> is now based on combination of two condition checks. Split out these
> condition as two separate checks to facilitate handling has_audio
> decision when we introduce audio bw checks in the follow up patches.
[..]
> @@ -2999,8 +2999,9 @@ intel_dp_audio_compute_config(struct intel_encoder *encoder,
>  			      struct intel_crtc_state *pipe_config,
>  			      struct drm_connector_state *conn_state)
>  {
> -	pipe_config->has_audio =
> -		intel_dp_has_audio(encoder, conn_state) &&
> +	pipe_config->has_audio = intel_dp_has_audio(encoder, conn_state);
> +
> +	pipe_config->has_audio = pipe_config->has_audio &&
>  		intel_audio_compute_config(pipe_config, conn_state);

this seems a bit superfluous as well to have as a separate patch. Maybe 
just squash to patch 5 where has_audio logic is extended?

Br, Kai