✗ Fi.CI.CHECKPATCH: warning for drm/i915/mst: cleanups, renames, clarifications (rev3)

Patchwork patchwork at emeril.freedesktop.org
Tue Nov 12 11:43:09 UTC 2024


== Series Details ==

Series: drm/i915/mst: cleanups, renames, clarifications (rev3)
URL   : https://patchwork.freedesktop.org/series/141068/
State : warning

== Summary ==

Error: dim checkpatch failed
fdde24d3fc2f drm/i915/mst: pass primary encoder to primary encoder hooks
-:22: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#22: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:1116:
+		dig_port->base.post_pll_disable(state, &dig_port->base, old_crtc_state, old_conn_state);

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
7f116139ea2d drm/i915/mst: rename intel_encoder to encoder
d1a7f6af5e5d drm/i915/mst: introduce to_primary_encoder() and to_primary_dp()
-:154: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#154: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:1126:
+		primary_encoder->post_pll_disable(state, primary_encoder, old_crtc_state, old_conn_state);

total: 0 errors, 1 warnings, 0 checks, 231 lines checked
c1ced3290a5a drm/i915/mst: use primary_encoder in fake mst encoder creation
0a4f50235fc9 drm/i915/display: make CHICKEN_TRANS() display version aware
-:227: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#227: FILE: drivers/gpu/drm/i915/i915_reg.h:2758:
+#define _CHICKEN_TRANS(trans)	_MMIO(_PICK((trans), \
 					    [TRANSCODER_EDP] = _CHICKEN_TRANS_EDP, \
 					    [TRANSCODER_A] = _CHICKEN_TRANS_A, \
 					    [TRANSCODER_B] = _CHICKEN_TRANS_B, \

-:239: WARNING:LONG_LINE: line length of 120 exceeds 100 columns
#239: FILE: drivers/gpu/drm/i915/i915_reg.h:2769:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

-:239: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'trans' - possible side-effects?
#239: FILE: drivers/gpu/drm/i915/i915_reg.h:2769:
+#define CHICKEN_TRANS(display, trans)	(DISPLAY_VER(display) >= 14 ? _MTL_CHICKEN_TRANS(trans) : _CHICKEN_TRANS(trans))

total: 1 errors, 1 warnings, 1 checks, 176 lines checked
4efd806852ab drm/i915/mst: convert to struct intel_display
2fce2c5e0634 drm/i915/mst: change naming from fake encoders to MST stream encoders
4ad6fc92efa0 drm/i915/dp: add comments about hooks called from MST stream encoders




More information about the Intel-gfx mailing list