[RFC PATCH 1/4] drm/i915/display: update intel_fbc_atomic_check for dirty_fbc support

Vinod Govindapillai vinod.govindapillai at intel.com
Mon Nov 18 23:53:22 UTC 2024


For the follw-up patches to enable the dirty rect support for
FBC, we need to have a provision to compare certain FBC specific
parameters between old plane state and new plane state. Update
intel_fbc_atomic_check() to get the old plane state as well.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index df05904bac8a..1fdb1a3e3fbe 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1666,11 +1666,13 @@ void intel_fbc_flush(struct drm_i915_private *i915,
 
 int intel_fbc_atomic_check(struct intel_atomic_state *state)
 {
-	struct intel_plane_state __maybe_unused *plane_state;
+	struct intel_plane_state __maybe_unused *new_plane_state;
+	struct intel_plane_state __maybe_unused *old_plane_state;
 	struct intel_plane *plane;
 	int i;
 
-	for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
+	for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state,
+					     new_plane_state, i) {
 		int ret;
 
 		ret = intel_fbc_check_plane(state, plane);
-- 
2.34.1



More information about the Intel-gfx mailing list