[PATCH 4/4] Revert "drm/i915/dpt: Make DPT object unshrinkable"
Srinivas, Vidya
vidya.srinivas at intel.com
Thu Nov 28 07:44:14 UTC 2024
Hello Ville,
Thank you so much. Changes Look Good to me.
Reviewed-by: Vidya Srinivas <vidya.srinivas at intel.com>
> -----Original Message-----
> From: Ville Syrjala <ville.syrjala at linux.intel.com>
> Sent: 27 November 2024 11:41
> To: intel-gfx at lists.freedesktop.org
> Cc: Brian Geffon <bgeffon at google.com>; Srinivas, Vidya
> <vidya.srinivas at intel.com>
> Subject: [PATCH 4/4] Revert "drm/i915/dpt: Make DPT object unshrinkable"
>
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> This reverts commit 51064d471c53dcc8eddd2333c3f1c1d9131ba36c.
>
> Now that we forcefully evict all DPT VMAs during suspend there should be no
> problem allowing the shrinker to eat the DPT objects.
>
> Cc: Brian Geffon <bgeffon at google.com>
> Cc: Vidya Srinivas <vidya.srinivas at intel.com>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12965
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> index 3dc61cbd2e11..bb713e096db2 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> @@ -283,9 +283,7 @@ bool i915_gem_object_has_iomem(const struct
> drm_i915_gem_object *obj); static inline bool
> i915_gem_object_is_shrinkable(const struct drm_i915_gem_object *obj) {
> - /* TODO: make DPT shrinkable when it has no bound vmas */
> - return i915_gem_object_type_has(obj,
> I915_GEM_OBJECT_IS_SHRINKABLE) &&
> - !obj->is_dpt;
> + return i915_gem_object_type_has(obj,
> I915_GEM_OBJECT_IS_SHRINKABLE);
> }
>
> static inline bool
> --
> 2.45.2
More information about the Intel-gfx
mailing list