✗ Fi.CI.CHECKPATCH: warning for drm/client: Stop using legacy crtc->mode and a bunch of cleanups

Patchwork patchwork at emeril.freedesktop.org
Thu Oct 3 17:57:59 UTC 2024


== Series Details ==

Series: drm/client: Stop using legacy crtc->mode and a bunch of cleanups
URL   : https://patchwork.freedesktop.org/series/139493/
State : warning

== Summary ==

Error: dim checkpatch failed
c792344099fd drm/client: Constify modes
dded8f971b9d drm/client: Use array notation for function arguments
5efbfc394267 drm/client: Streamline mode selection debugs
53b2c61a53f2 drm/client: Make copies of modes
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 3eadd887dbac ("drm/client: Fully protect modes[] with dev->mode_config.mutex")'
#21: 
And with this we can undo also commit 3eadd887dbac
("drm/client:Fully protect modes[] with dev->mode_config.mutex")

-:131: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#131: FILE: drivers/gpu/drm/drm_client_modeset.c:458:
+			drm_mode_copy(&modes[i], drm_connector_preferred_mode(connector, width, height));

-:147: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#147: FILE: drivers/gpu/drm/drm_client_modeset.c:481:
+				drm_mode_copy(&modes[i], drm_connector_fallback_non_tiled_mode(connector));

-:211: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#211: FILE: drivers/gpu/drm/drm_client_modeset.c:703:
+			drm_mode_copy(&modes[i], drm_connector_preferred_mode(connector, width, height));

total: 1 errors, 3 warnings, 0 checks, 235 lines checked
2c97e1fbfe26 drm/client: Stop using the legacy crtc->mode
e690a0ca1b17 drm/client: s/new_crtc/crtc/
761f32dfac6c drm/client: Move variables to tighter scope
44f98be57a2b drm/client: s/unsigned int i/int i/




More information about the Intel-gfx mailing list