[PATCH 30/31] drm/xe/display: Add missing power display handling on non-d3cold rpm

[Cavitt, Jonathan]

-----Original Message-----
From: Intel-xe <intel-xe-bounces at lists.freedesktop.org> On Behalf Of Rodrigo Vivi
Sent: Tuesday, September 24, 2024 1:36 PM
To: intel-gfx at lists.freedesktop.org; intel-xe at lists.freedesktop.org
Cc: Deak, Imre <imre.deak at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>
Subject: [PATCH 30/31] drm/xe/display: Add missing power display handling on non-d3cold rpm
> 
> On the regular igfx runtime pm sequence where d3cold is not
> possible, the proper calls to power display are required.
> 
> Align with i915.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

LGTM.

Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 23bdd8904c44..ab85c7fb217a 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -415,6 +415,8 @@ void xe_display_pm_runtime_suspend(struct xe_device *xe)
>  
>  	if (xe->d3cold.allowed)
>  		xe_display_to_d3cold(xe);
> +	else
> +		intel_display_power_suspend(xe);
>  }
>  
>  void xe_display_pm_runtime_suspend_late(struct xe_device *xe)
> @@ -435,10 +437,12 @@ void xe_display_pm_runtime_resume_early(struct xe_device *xe)
>  	if (!xe->info.probe_display)
>  		return;
>  
> -	if (xe->d3cold.allowed)
> +	if (xe->d3cold.allowed) {
>  		intel_display_power_resume_early(xe);
> -	else
> +	} else {
>  		intel_opregion_notify_adapter(&xe->display, PCI_D0);
> +		intel_display_power_resume(xe);
> +	}
>  }
>  
>  void xe_display_pm_runtime_resume(struct xe_device *xe)
> -- 
> 2.46.0
> 
>