[PATCH] drm/i915/dmc: Add dmc null check

[Kandpal, Suraj]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Wednesday, October 9, 2024 3:01 PM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-
> xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar at intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah at intel.com>; Kandpal, Suraj
> <suraj.kandpal at intel.com>
> Subject: Re: [PATCH] drm/i915/dmc: Add dmc null check
> 
> On Wed, 09 Oct 2024, Suraj Kandpal <suraj.kandpal at intel.com> wrote:
> > Add dmc null check before dereferncing to get the major and minor
> > version.
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_dmc.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c
> > b/drivers/gpu/drm/i915/display/intel_dmc.c
> > index 48bbbf8f312c..8c193de0e253 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> > @@ -1263,8 +1263,9 @@ static int intel_dmc_debugfs_status_show(struct
> seq_file *m, void *unused)
> >  	if (!intel_dmc_has_payload(display))
> 
> See what this does.

Ahh ohkay got it.


> 
> BR,
> Jani.
> 
> >  		goto out;
> >
> > -	seq_printf(m, "version: %d.%d\n", DMC_VERSION_MAJOR(dmc-
> >version),
> > -		   DMC_VERSION_MINOR(dmc->version));
> > +	if (dmc)
> > +		seq_printf(m, "version: %d.%d\n",
> DMC_VERSION_MAJOR(dmc->version),
> > +			   DMC_VERSION_MINOR(dmc->version));
> >
> >  	if (DISPLAY_VER(display) >= 12) {
> >  		i915_reg_t dc3co_reg;
> 
> --
> Jani Nikula, Intel