[PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting

[Kahola, Mika]

> -----Original Message-----
> From: Jadav, Raag <raag.jadav at intel.com>
> Sent: Tuesday, 29 October 2024 19.03
> To: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Kahola, Mika <mika.kahola at intel.com>; intel-gfx at lists.freedesktop.org;
> Sousa, Gustavo <gustavo.sousa at intel.com>
> Subject: Re: [PATCH v3] drm/i915/xe3lpd: Power request asserting/deasserting
> 
> On Tue, Oct 29, 2024 at 04:41:29PM +0200, Jani Nikula wrote:
> > On Tue, 29 Oct 2024, Mika Kahola <mika.kahola at intel.com> wrote:
> 
> ...
> 
> > > +static void wa_14020908590(struct intel_display *display,
> > > +			   bool enable)
> > > +{
> > > +	bool error = false;
> > > +
> > > +	/* check if mailbox is running busy */
> > > +	if (intel_de_wait_for_clear(display, TCSS_DISP_MAILBOX_IN_CMD,
> > > +				    TCSS_DISP_MAILBOX_IN_CMD_RUN_BUSY,
> 10)) {
> > > +		drm_dbg_kms(display->drm,
> > > +			    "Timeout waiting for TCSS mailbox run/busy bit to
> clear\n");
> >
> > Just do drm_WARN() with the message here.
> 
> Rather,
> 
> 	ret = intel_de_wait_for_clear();
> 	if (drm_WARN(drm, ret, ...))
> 		return;
> 
> Cleaner?

Maybe we could drop the drm_WARN_ON() completely? This is something that we are not really using elsewhere in the driver. Simply drm_dbg_kms() on timeouts has so far been enough. What do you think?

> 
> Raag