[PATCH v3 05/81] drm/fbdev-dma: Support struct drm_driver.fbdev_probe

[Thomas Zimmermann]

Hi

Am 03.09.24 um 13:08 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann at suse.de> writes:
>
>> Rework fbdev probing to support fbdev_probe in struct drm_driver
>> and reimplement the old fb_probe callback on top of it. Provide an
>> initializer macro for struct drm_driver that sets the callback
>> according to the kernel configuration.
>>
>> This change allows the common fbdev client to run on top of DMA-
>> based DRM drivers.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> ---
>>   drivers/gpu/drm/drm_fbdev_dma.c | 60 ++++++++++++++++++++-------------
>>   include/drm/drm_fbdev_dma.h     | 12 +++++++
>>   2 files changed, 48 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
>> index 7ef5a48c8029..aeccf7f7a522 100644
>> --- a/drivers/gpu/drm/drm_fbdev_dma.c
>> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
>> @@ -86,6 +86,40 @@ static const struct fb_ops drm_fbdev_dma_fb_ops = {
>>   
>>   static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper,
>>   					 struct drm_fb_helper_surface_size *sizes)
>> +{
> static inline for this wrapper maybe ?

It's only called indirectly via drm_fb_helper_funcs.fb_probe. So it 
needs an address. It well be removed later in the series when all 
related drivers have been converted.

Best regards
Thomas

>
>> +	return drm_fbdev_dma_driver_fbdev_probe(fb_helper, sizes);
>> +}
>> +
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)