✗ Fi.CI.CHECKPATCH: warning for Ultrajoiner basic functionality series (rev7)

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 6 14:08:36 UTC 2024


== Series Details ==

Series: Ultrajoiner basic functionality series (rev7)
URL   : https://patchwork.freedesktop.org/series/133800/
State : warning

== Summary ==

Error: dim checkpatch failed
f0319f26329c drm/i915/display: Modify debugfs for joiner to force n pipes
c990cc40b2c9 drm/i915/display: Use joined pipes in intel_dp_joiner_needs_dsc
6a7298b1549d drm/i915/display: Use joined pipes in intel_mode_valid_max_plane_size
997453c80592 drm/i915/display: Use joined pipes in dsc helpers for slices, bpp
185c7a362580 drm/i915: Add some essential functionality for joiners
e589900b4e56 drm/i915: Split current joiner hw state readout
dbc40a7ee871 drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity checks
aff7471b9657 drm/i915: Implement hw state readout and checks for ultrajoiner
aa050e4a1a58 drm/i915/display: Add helpers to check for ultrajoiner primary
13e5f0c73c6e drm/i915/display/vdsc: Add ultrajoiner support with DSC
87c324295490 drm/i915: Add new abstraction layer to handle pipe order for different joiners
-:231: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#231: FILE: drivers/gpu/drm/i915/display/intel_display.h:278:
+#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \
+	for_each_pipe(__dev_priv, __p) \
+		for_each_if((__mask) & BIT(__priolist[__p])) \
+			for_each_if(intel_crtc = intel_crtc_for_pipe(to_intel_display(&__dev_priv->drm), __priolist[__p]))

-:231: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__dev_priv' - possible side-effects?
#231: FILE: drivers/gpu/drm/i915/display/intel_display.h:278:
+#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \
+	for_each_pipe(__dev_priv, __p) \
+		for_each_if((__mask) & BIT(__priolist[__p])) \
+			for_each_if(intel_crtc = intel_crtc_for_pipe(to_intel_display(&__dev_priv->drm), __priolist[__p]))

-:231: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__p' - possible side-effects?
#231: FILE: drivers/gpu/drm/i915/display/intel_display.h:278:
+#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \
+	for_each_pipe(__dev_priv, __p) \
+		for_each_if((__mask) & BIT(__priolist[__p])) \
+			for_each_if(intel_crtc = intel_crtc_for_pipe(to_intel_display(&__dev_priv->drm), __priolist[__p]))

-:231: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__priolist' - possible side-effects?
#231: FILE: drivers/gpu/drm/i915/display/intel_display.h:278:
+#define for_each_intel_crtc_in_mask_priority(__dev_priv, intel_crtc, __p, __mask, __priolist) \
+	for_each_pipe(__dev_priv, __p) \
+		for_each_if((__mask) & BIT(__priolist[__p])) \
+			for_each_if(intel_crtc = intel_crtc_for_pipe(to_intel_display(&__dev_priv->drm), __priolist[__p]))

-:234: WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#234: FILE: drivers/gpu/drm/i915/display/intel_display.h:281:
+			for_each_if(intel_crtc = intel_crtc_for_pipe(to_intel_display(&__dev_priv->drm), __priolist[__p]))

total: 1 errors, 1 warnings, 3 checks, 250 lines checked
408e3cb74a24 drm/i915: Compute config and mode valid changes for ultrajoiner
12981c443053 drm/i915/display: Consider ultrajoiner for computing maxdotclock
a4c718aa641a drm/i915/intel_dp: Add support for forcing ultrajoiner




More information about the Intel-gfx mailing list