✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some intel_display conversions

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 6 15:43:39 UTC 2024


== Series Details ==

Series: drm/i915: Some intel_display conversions
URL   : https://patchwork.freedesktop.org/series/138331/
State : warning

== Summary ==

Error: dim checkpatch failed
0f1a2e1d9ca9 drm/i915/cdclk: Add missing braces
f31c381fad0a drm/i915/cdclk: Convert CDCLK code to intel_display
-:1467: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 26)
#1467: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2103:
+	if (DISPLAY_VER(display) >= 14 || IS_DG2(dev_priv))
 		/* NOOP */;

-:1508: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 19)
#1508: FILE: drivers/gpu/drm/i915/display/intel_cdclk.c:2140:
+	if (DISPLAY_VER(display) >= 14)
[...]
 		 */;

-:2895: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#2895: FILE: drivers/gpu/drm/i915/display/intel_display_driver.c:95:
+	cdclk_state->logical = cdclk_state->actual = display->cdclk.hw;

total: 0 errors, 2 warnings, 1 checks, 2934 lines checked
e8bcf398a0cc drm/i915/power: Convert low level DC state code to intel_display
55bd47b4af6b drm/i915/vga: Convert VGA code to intel_display
1f4c4c02e55e drm/i915/power: Convert "i830 power well" code to intel_display
6fbc2c329423 drm/i915/dmc: Convert DMC code to intel_display
-:603: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#603: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:645:
+		      !intel_de_read(display, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)),

-:710: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#710: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:821:
+			    is_dmc_evt_ctl_reg(display, dmc_id, dmc_info->mmioaddr[i]) ? " (EVT_CTL)" :

-:711: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#711: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:822:
+			    is_dmc_evt_htp_reg(display, dmc_id, dmc_info->mmioaddr[i]) ? " (EVT_HTP)" : "",

-:1169: WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#1169: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:1274:
+		   intel_de_read(display, DMC_PROGRAM(dmc->dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)));

total: 0 errors, 4 warnings, 0 checks, 1210 lines checked




More information about the Intel-gfx mailing list