[PATCHv2 5/5] drm/i915/display/histogram: Histogram changes for Display LNL+

[Murthy, Arun R]

> > @@ -161,12 +191,19 @@ static int intel_histogram_enable(struct
> > intel_crtc
> > *intel_crtc)
> >  	 * enable DPST_CTL Histogram mode
> >  	 * Clear DPST_CTL Bin Reg function select to TC
> >  	 */
> > -	intel_de_rmw(i915, DPST_CTL(pipe),
> > -		     DPST_CTL_BIN_REG_FUNC_SEL | DPST_CTL_IE_HIST_EN |
> > -		     DPST_CTL_HIST_MODE |
> > DPST_CTL_IE_TABLE_VALUE_FORMAT,
> > -		     DPST_CTL_BIN_REG_FUNC_TC | DPST_CTL_IE_HIST_EN |
> > -		     DPST_CTL_HIST_MODE_HSV |
> > -		     DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
> > +	if (DISPLAY_VER(i915) >= 20)
> > +		intel_de_rmw(i915, DPST_CTL(pipe),
> > +			     DPST_CTL_IE_HIST_EN |
> > +			     DPST_CTL_HIST_MODE,
> > +			     DPST_CTL_IE_HIST_EN |
> > +			     DPST_CTL_HIST_MODE_HSV);
> > +	else
> > +		intel_de_rmw(i915, DPST_CTL(pipe),
> > +			     DPST_CTL_BIN_REG_FUNC_SEL |
> > DPST_CTL_IE_HIST_EN |
> > +			     DPST_CTL_HIST_MODE |
> > DPST_CTL_IE_TABLE_VALUE_FORMAT,
> > +			     DPST_CTL_BIN_REG_FUNC_TC |
> > DPST_CTL_IE_HIST_EN |
> > +			     DPST_CTL_HIST_MODE_HSV |
> > +
> > DPST_CTL_IE_TABLE_VALUE_FORMAT_1INT_9FRAC);
> >
> I checked the Spec looks like this wait_for_vblank is not present. As the step 1
> itself differs here and there is no need of putting in TC mode.
> 
This is required to get the histogram enable and then after enabling histogram, the guardband values are to be written.

Thanks and Regards,
Arun R Murthy
--------------------