[PATCH 3/5] Add crtc properties for global histogram

Murthy, Arun R arun.r.murthy at intel.com
Thu Sep 12 09:52:05 UTC 2024


> > @@ -7503,6 +7508,14 @@ static void intel_atomic_commit_tail(struct
> > intel_atomic_state *state)
> >  		 * FIXME get rid of this funny new->old swapping
> >  		 */
> >  		old_crtc_state->dsb = fetch_and_zero(&new_crtc_state-
> > >dsb);
> > +
> 
> Since there is a wait_for_vblank in this for older platforms only, what is the
> expected user space behaviour here for enabling histogram and updating the
> iets.

This wait is for all the platforms and is required after enabling histogram and before programming the guardband registers.
User space will have no impact as this histogram event is not generated immediately. It's a statistics of 'n' number of frames.

Thanks and Regards,
Arun R Murthy
--------------------


More information about the Intel-gfx mailing list