[PATCH 3/3] drm/i915/irq: Rename suspend/resume funcitons

Rodrigo Vivi rodrigo.vivi at intel.com
Mon Sep 16 15:37:13 UTC 2024


On Fri, Sep 13, 2024 at 11:07:33AM +0200, Andi Shyti wrote:
> Hi Rodrigo,
> 
> On Thu, Sep 12, 2024 at 01:25:39PM GMT, Rodrigo Vivi wrote:
> > Although these functions are used in runtime_pm, they are not
> > exclusively used there, so remove the misleading prefix.
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
> 
> A general note, please add a cover letter even if the series
> looks trivial. It's important to have an overview of what the
> series does.

You are absolutely right. I'm sorry!

On a 1 or 2 patch series I don't like seeing cover letters, but
on a 3+ patches, specially on the first submission I believe it
is important.

And it helps maintainers to writing the pull-request notes later.

Thanks for the review and for the note,
Rodrigo.

> 
> Thanks,
> Andi


More information about the Intel-gfx mailing list