[PATCH 3/5] Add crtc properties for global histogram

[Murthy, Arun R]

> > > +static int intel_crtc_get_property(struct drm_crtc *crtc,
> > > +				   const struct drm_crtc_state *state,
> > > +				   struct drm_property *property,
> > > +				   uint64_t *val)
> > > +{
> > > +	struct drm_i915_private *i915 = to_i915(crtc->dev);
> > > +	const struct intel_crtc_state *intel_crtc_state =
> > > +		to_intel_crtc_state(state);
> > > +	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
> > > +
> > > +	if (property == intel_crtc->histogram_en_property) {
> > > +		*val = intel_crtc_state->histogram_en;
> > > +	} else if (property == intel_crtc->global_iet_property) {
> > > +		*val = (intel_crtc_state->global_iet) ?
> > > +			intel_crtc_state->global_iet->base.id : 0;
> > > +	} else if (property == intel_crtc->histogram_property) {
> > > +		*val = (intel_crtc_state->histogram) ?
> > > +			intel_crtc_state->histogram->base.id : 0;
> > > +	} else {
> > > +		drm_err(&i915->drm,
> > > +			"Unknown property [PROP:%d:%s]\n",
> > > +			property->base.id, property->name);
> > > +		return -EINVAL;
> > > +	}
> > > +
> > > +	return 0;
> > > +}
> > > +
> Also to me the below function looks like drm_property_replace_blob_from_id,
> why are we not using that, am I missing something here..
> 
This function was not exposed from drm when this patch was initially developed.
Thanks will make us of this function.

Thanks and Regards,
Arun R Murthy
--------------------