[PATCH 0/2] drm: revert some framebuffer API tests

Jani Nikula jani.nikula at intel.com
Tue Sep 17 17:43:50 UTC 2024


The tests consistently trigger WARNs in drm_framebuffer code. I'm not
sure what the point is with type of belts and suspenders tests. The
warnings *are* the way to flag erroneous API usage.

Warnings in turn trigger failures in CI. Filtering the warnings are
error prone, and, crucially, would also filter actual errors in case the
kunit tests are not run.

I acknowledge there may be complex test cases where you'd end up
triggering warnings somewhere deep, but these are not it. These are
simple.

Revert the tests, back to the drawing board.

BR,
Jani.


Cc: Carlos Eduardo Gallo Filho <gcarlos at disroot.org>
Cc: Maxime Ripard <mripard at kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Thomas Zimmermann <tzimmermann at suse.de>
Cc: Jeff Johnson <quic_jjohnson at quicinc.com>


Jani Nikula (2):
  Revert "drm/tests: Add test for drm_framebuffer_free()"
  Revert "drm/tests: Add test for drm_framebuffer_init()"

 drivers/gpu/drm/drm_framebuffer.c            |   1 -
 drivers/gpu/drm/drm_mode_object.c            |   1 -
 drivers/gpu/drm/tests/drm_framebuffer_test.c | 134 -------------------
 3 files changed, 136 deletions(-)

-- 
2.39.2



More information about the Intel-gfx mailing list