[PATCH 5/5] drm/i915/bios: Extract soc/intel_rom.c

Jani Nikula jani.nikula at linux.intel.com
Mon Sep 23 09:13:53 UTC 2024


On Fri, 20 Sep 2024, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Thu, Sep 12, 2024 at 03:44:32PM +0300, Jani Nikula wrote:
>> Just nitpicking, but should this (and rom reads above) now sanity check
>> offset+size against rom->size? IDK if it's worth it for such a simple
>> thing. The caller is supposed to know what it's doing.
>
> I considered that but decided to cut my losses before I
> end up designing a whole new kernel subsystem.

Good call. :)

BR,
Jani.


-- 
Jani Nikula, Intel


More information about the Intel-gfx mailing list