[PATCH v6 1/4] drm: Introduce device wedged event

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Sep 23 14:57:56 UTC 2024


On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote:
> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote:
> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote:

...

> > > +extern const char *const wedge_recovery_opts[];
> > 
> > It's not NULL terminated. How users will know that they have an index valid?
> 
> It's expected to be accessed using recovery_*() helpers.

If so, this has to be static then.

> > Either you NULL-terminate that, or export the size as well (personally I would
> > go with the first approach).

-- 
With Best Regards,
Andy Shevchenko




More information about the Intel-gfx mailing list