[PATCH] drm/i915/scaler: Fix for WA_14011503117

[Garg, Nemesa]

> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com>
> Sent: Wednesday, August 6, 2025 2:40 PM
> To: Garg, Nemesa <nemesa.garg at intel.com>; intel-gfx at lists.freedesktop.org
> Cc: Garg, Nemesa <nemesa.garg at intel.com>
> Subject: Re: [PATCH] drm/i915/scaler: Fix for WA_14011503117
> 
> On Wed, 06 Aug 2025, Nemesa Garg <nemesa.garg at intel.com> wrote:
> > Remove the redundant check statement.
> 
> What if scaler_state->scaler_id == -1?
> 
This is being called in case of pipe scaler getting used so scaler_id will be 0 or 1.
But yes adding this check can prevent the spurious write.

Thanks,
Nemesa 

> >
> > Fixes: 73309ed9d598 ("drm/i915/display: WA_14011503117")
> > Signed-off-by: Nemesa Garg <nemesa.garg at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/skl_scaler.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c
> b/drivers/gpu/drm/i915/display/skl_scaler.c
> > index cd7ebbeb9508..602198798174 100644
> > --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> > +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> > @@ -960,9 +960,6 @@ void adl_scaler_ecc_unmask(const struct
> intel_crtc_state *crtc_state)
> >  	const struct intel_crtc_scaler_state *scaler_state =
> >  		&crtc_state->scaler_state;
> >
> > -	if (!scaler_state && scaler_state->scaler_id == -1)
> > -		return;
> > -
> >  	intel_de_write_fw(display,
> >  			  SKL_PS_ECC_STAT(crtc->pipe, scaler_state-
> >scaler_id),
> >  			  1);
> 
> --
> Jani Nikula, Intel